- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.8k
feat(NODE-4696): add FaaS env information to client metadata #3626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            durran
  merged 33 commits into
  main
from
NODE-4696-faas-metadata-handshake-5x-spec-updates
  
      
      
   
  Apr 12, 2023 
      
    
                
     Merged
            
            feat(NODE-4696): add FaaS env information to client metadata #3626
                    durran
  merged 33 commits into
  main
from
NODE-4696-faas-metadata-handshake-5x-spec-updates
  
      
      
   
  Apr 12, 2023 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    9aee3fe    to
    871d208      
    Compare
  
    
      
        
      
      
  
    5 tasks
  
              
                    nbbeeken
  
              
              commented
              
                  
                    Apr 6, 2023 
                  
              
              
            
            
              
                    durran
  
              
              requested changes
              
                  
                    Apr 7, 2023 
                  
              
              
            
            
              
                    dariakp
  
              
              requested changes
              
                  
                    Apr 11, 2023 
                  
              
              
            
            
        
          
                test/integration/mongodb-handshake/mongodb-handshake.prose.test.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    dariakp
  
              
              reviewed
              
                  
                    Apr 12, 2023 
                  
              
              
            
            
              
                    dariakp
  
              
              approved these changes
              
                  
                    Apr 12, 2023 
                  
              
              
            
            
              
                    durran
  
              
              approved these changes
              
                  
                    Apr 12, 2023 
                  
              
              
            
            
    
  W-A-James 
      pushed a commit
      that referenced
      this pull request
    
      Apr 12, 2023 
    
    
  
    
  baileympearson 
      added a commit
      that referenced
      this pull request
    
      Apr 13, 2023 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
What is changing?
helloDoc.client.driver.nameproperty which is required server sideosuntil it can fit, followed by the same logic forenvIs there new documentation needed for these changes?
No mongodb manual changes.
I changed the API docs above MongoOptions, this is made public by the client.options getter and represents the parsed options, the type isn't necessarily an accurate representation of the runtime value because there are properties that are set after SRV lookup.
What is the motivation for this change?
FaaS environments have a unique impact on the driver's approach to it's distributed systems logic (SDAM). If we can better understand the environments & resources being used we can provide the best FaaS experience possible.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript